Skip to content

Conversation

GuillaumeGomez
Copy link
Member

r? @QuietMisdreavus

And of course, a few screenshots:

screen shot 2017-09-17 at 22 08 46

screen shot 2017-09-17 at 22 09 47

screen shot 2017-09-17 at 22 10 56

@QuietMisdreavus
Copy link
Contributor

So how does this look with the existing class="anchor" links? I see the new ones here put the anchor before the text in the header, but the previous ones had it after. Does the position: absolute in the CSS make it not matter?

@GuillaumeGomez
Copy link
Member Author

position: absolute; and left: ...px;.

@GuillaumeGomez
Copy link
Member Author

New screenshot as requested on IRC:

screen shot 2017-09-17 at 22 25 09

@QuietMisdreavus
Copy link
Contributor

r=me pending travis

@GuillaumeGomez
Copy link
Member Author

@bors: r=QuietMisdreavus

@bors
Copy link
Collaborator

bors commented Sep 17, 2017

📌 Commit e47279f has been approved by QuietMisdreavus

@carols10cents carols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 18, 2017
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 18, 2017
…isdreavus

Add more links and put the link character to the left

r? @QuietMisdreavus

And of course, a few screenshots:

<img width="1440" alt="screen shot 2017-09-17 at 22 08 46" src="https://user-images.githubusercontent.com/3050060/30524496-44a50208-9bf5-11e7-942e-a3707ba125c3.png">
<img width="1440" alt="screen shot 2017-09-17 at 22 09 47" src="https://user-images.githubusercontent.com/3050060/30524502-49068dbc-9bf5-11e7-8e59-ec38664e0e0f.png">
<img width="1440" alt="screen shot 2017-09-17 at 22 10 56" src="https://user-images.githubusercontent.com/3050060/30524503-491c8c34-9bf5-11e7-9ce5-f1bd5ef8600b.png">
bors added a commit that referenced this pull request Sep 18, 2017
Rollup of 10 pull requests

- Successful merges: #44364, #44466, #44537, #44640, #44651, #44657, #44661, #44668, #44671, #44675
- Failed merges:
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 18, 2017
…isdreavus

Add more links and put the link character to the left

r? @QuietMisdreavus

And of course, a few screenshots:

<img width="1440" alt="screen shot 2017-09-17 at 22 08 46" src="https://user-images.githubusercontent.com/3050060/30524496-44a50208-9bf5-11e7-942e-a3707ba125c3.png">
<img width="1440" alt="screen shot 2017-09-17 at 22 09 47" src="https://user-images.githubusercontent.com/3050060/30524502-49068dbc-9bf5-11e7-8e59-ec38664e0e0f.png">
<img width="1440" alt="screen shot 2017-09-17 at 22 10 56" src="https://user-images.githubusercontent.com/3050060/30524503-491c8c34-9bf5-11e7-9ce5-f1bd5ef8600b.png">
bors added a commit that referenced this pull request Sep 18, 2017
Rollup of 11 pull requests

- Successful merges: #44364, #44466, #44537, #44548, #44640, #44651, #44657, #44661, #44668, #44671, #44675
- Failed merges:
@bors bors merged commit e47279f into rust-lang:master Sep 18, 2017
@GuillaumeGomez GuillaumeGomez deleted the more-links branch September 19, 2017 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants